test(amazonq): E2E test for /doc #6215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/runIntegrationTests |
KevinDing1
approved these changes
Dec 11, 2024
Contributor
Author
|
Approved for next week's release |
jpinkney-aws
approved these changes
Dec 12, 2024
willyyhuang
reviewed
Dec 12, 2024
| import { i18n } from 'aws-core-vscode/shared' | ||
| import { docGenerationProgressMessage, DocGenerationStep, Mode } from 'aws-core-vscode/amazonqDoc' | ||
|
|
||
| describe('Amazon Q Doc', async function () { |
Contributor
There was a problem hiding this comment.
Suggested change
| describe('Amazon Q Doc', async function () { | |
| describe('Amazon Q /doc', async function () { |
|
|
||
| async waitForText(text: string, waitOverrides?: MessengerOptions) { | ||
| await this.waitForEvent(() => { | ||
| console.log(this.getChatItems()) |
Contributor
There was a problem hiding this comment.
tbh i think the console logs are useful. When you have a set of e2e tests that take a look time to run its usually a lot easier to see why they failed by looking at what chat items are present
Contributor
There was a problem hiding this comment.
We should technically only log chat items when we encounter an error'd test though, otherwise theres just going to be a lot of spam in the logs
Contributor
Author
There was a problem hiding this comment.
yeah this was accidentally added to the commit
Contributor
Author
|
/runIntegrationTests |
justinmk3
reviewed
Dec 12, 2024
| afterEach(() => { | ||
| framework.removeTab(tab.tabID) | ||
| framework.dispose() | ||
| sinon.restore() |
Contributor
There was a problem hiding this comment.
why is sinon needed in e2e tests? if this is part of the qTestingFramework, then I would expect framework.dispose() to take care of it.
jpinkney-aws
pushed a commit
to jpinkney-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 6, 2025
Add an E2E test for Creating a README using /doc Moved reusable functions out of featureDev.test.ts to shared test framework --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
Add an E2E test for Creating a README using /doc Moved reusable functions out of featureDev.test.ts to shared test framework --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an E2E test for Creating a README using /doc
Moved reusable functions out of featureDev.test.ts to shared test framework
feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.