refactor(ec2): swap order of icons. #6224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
Dec 12, 2024
justinmk3
reviewed
Dec 12, 2024
justinmk3
reviewed
Dec 12, 2024
| "AWS.command.ec2.openTerminal": "Open terminal to EC2 instance...", | ||
| "AWS.command.ec2.openRemoteConnection": "Connect to EC2 instance in New Window...", | ||
| "AWS.command.ec2.openTerminal": "Connect Terminal to EC2 Instance...", | ||
| "AWS.command.ec2.openRemoteConnection": "Connect VS Code to EC2 Instance...", |
Contributor
There was a problem hiding this comment.
Normally we would avoid hardcoding the IDE name. But since vscode remote-ssh requires VSCode, this works for now.
justinmk3
approved these changes
Dec 12, 2024
justinmk3
reviewed
Dec 12, 2024
| { | ||
| "command": "aws.ec2.linkToLaunch", | ||
| "group": "0@1", | ||
| "group": "0@0", |
Contributor
There was a problem hiding this comment.
Does this avoid the need for the command name changes? We probably should stick with Open Terminal if possible, since we use that in the command-palette names, and for ECS, CodeCatalyst, etc.
Contributor
Author
There was a problem hiding this comment.
Yea it does, I can swap it back.
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
## Problem EC2 icons are in an awkward order with the link to launch in-between the two connect options. ## Solution https://stackoverflow.com/questions/47613141/how-to-specify-the-order-of-icons-in-an-explorer-view-in-a-vscode-extension. Also update descriptions to fit UX guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The icons are in an awkward order with the link to launch in-between the two connect options.
Solution
(https://stackoverflow.com/questions/47613141/how-to-specify-the-order-of-icons-in-an-explorer-view-in-a-vscode-extension.)
What it looks like now:
This PR also updates some descriptions to fit with conventions.
feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.