Skip to content

Conversation

@spfink
Copy link
Contributor

@spfink spfink commented Dec 13, 2024

Problem

When working on new features available to AB groups, the new action are not easily discoverable to users

Solution

Add the ability to send a new command that will appear when a user types @ in the chat window


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@spfink spfink requested review from a team as code owners December 13, 2024 19:58
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@spfink spfink changed the title Adds capability to send new context commands to AB groups feat(amazonq): Adds capability to send new context commands to AB groups Dec 13, 2024
@spfink spfink force-pushed the finks/highlight-commands branch 3 times, most recently from 9f9deb2 to 9103775 Compare December 13, 2024 21:04
@justinmk3
Copy link
Contributor

justinmk3 commented Dec 16, 2024

⛔️ Not planned for tomorrow's release.

@spfink spfink force-pushed the finks/highlight-commands branch 2 times, most recently from 1c741c7 to 55e32df Compare January 14, 2025 06:38
// @ts-ignore
let featureConfigs: Map<string, FeatureContext> = tryNewMap(featureConfigsSerialized)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, this was existing code just moved up from lines 127 as you can see below. I can try and run a build without it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the annotation since this is now used in many places

@spfink spfink closed this Jan 14, 2025
@spfink spfink force-pushed the finks/highlight-commands branch from 55e32df to c9b4746 Compare January 14, 2025 20:21
@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@spfink spfink reopened this Jan 14, 2025
@hayemaxi hayemaxi merged commit 613bf5f into aws:master Jan 14, 2025
17 of 18 checks passed
avi-alpert pushed a commit to avi-alpert/aws-toolkit-vscode that referenced this pull request Jan 15, 2025
…ws#6239)

## Problem

When working on new features available to AB groups, the new action are
not easily discoverable to users

## Solution

Add the ability to send a new command that will appear when a user types
@ in the chat window

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).

License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
…ws#6239)

## Problem

When working on new features available to AB groups, the new action are
not easily discoverable to users

## Solution

Add the ability to send a new command that will appear when a user types
@ in the chat window

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).

License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
kevluu-aws pushed a commit to kevluu-aws/aws-toolkit-vscode that referenced this pull request Jan 23, 2025
…ws#6239)

## Problem

When working on new features available to AB groups, the new action are
not easily discoverable to users

## Solution

Add the ability to send a new command that will appear when a user types
@ in the chat window

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).

License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
…ws#6239)

## Problem

When working on new features available to AB groups, the new action are
not easily discoverable to users

## Solution

Add the ability to send a new command that will appear when a user types
@ in the chat window

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).

License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants