Skip to content

telemetry(amazonq): add jobId to all metrics #6241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinmk3 merged 2 commits into from
Dec 13, 2024
Merged

telemetry(amazonq): add jobId to all metrics #6241

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2033809
fix(amazonq): add jobId to all metrics
Dec 13, 2024
2761021
add jobId in once more
Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"generateNonCodeFiles": "npm run generateNonCodeFiles -w packages/ --if-present"
},
"devDependencies": {
"@aws-toolkits/telemetry": "^1.0.287",
"@aws-toolkits/telemetry": "^1.0.289",
"@playwright/browser-chromium": "^1.43.1",
"@stylistic/eslint-plugin": "^2.11.0",
"@types/he": "^1.2.3",
Expand Down
2 changes: 2 additions & 0 deletions packages/core/src/codewhisperer/commands/startTransformByQ.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ export async function preTransformationUploadCode() {

transformByQState.setPayloadFilePath(payloadFilePath)
uploadId = await uploadPayload(payloadFilePath)
telemetry.record({ codeTransformJobId: uploadId }) // uploadId is re-used as jobId
})
} catch (err) {
const errorMessage = (err as Error).message
Expand Down Expand Up @@ -825,6 +826,7 @@ export async function stopTransformByQ(jobId: string) {
await telemetry.codeTransform_jobIsCancelledByUser.run(async () => {
telemetry.record({
codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
codeTransformJobId: jobId,
})
if (transformByQState.isRunning()) {
getLogger().info('CodeTransformation: User requested to stop transformation. Stopping transformation.')
Expand Down
3 changes: 1 addition & 2 deletions packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,9 +536,9 @@ export class ProposedTransformationExplorer {
diffModel.saveChanges()
telemetry.codeTransform_submitSelection.emit({
Copy link
Contributor Author

@dhasani23 dhasani23 Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in a run block, have been slowly working on converting all of our metrics to use run blocks, mostly done but the old emit calls are still lingering around in a few places like here

codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
codeTransformJobId: transformByQState.getJobId(),
userChoice: `acceptChanges-${patchFilesDescriptions?.content[diffModel.currentPatchIndex].name}`,
})
telemetry.ui_click.emit({ elementId: 'transformationHub_acceptChanges' })
Copy link
Contributor Author

@dhasani23 dhasani23 Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not useful / redundant, and nobody looked at these ui_click metrics

if (transformByQState.getMultipleDiffs()) {
void vscode.window.showInformationMessage(
CodeWhispererConstants.changesAppliedNotificationMultipleDiffs(
Expand Down Expand Up @@ -596,7 +596,6 @@ export class ProposedTransformationExplorer {
vscode.commands.registerCommand('aws.amazonq.transformationHub.reviewChanges.rejectChanges', async () => {
diffModel.rejectChanges()
await reset()
telemetry.ui_click.emit({ elementId: 'transformationHub_rejectChanges' })

transformByQState.getChatControllers()?.transformationFinished.fire({
tabID: ChatSessionManager.Instance.getSession().tabID,
Expand Down
Loading