refactor(settings): minimize duplication across prompt settings. #6243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hweinstock
commented
Dec 16, 2024
| ) { | ||
| public isPromptEnabled(promptName: promptName) { | ||
| try { | ||
| return !this._getOrThrow(promptName, false as never) |
Contributor
Author
There was a problem hiding this comment.
Believe there is an issue with how I setup types since I need the cast here.
justinmk3
reviewed
Dec 16, 2024
|
|
||
| // We know 'ssoCacheError' is in all extension prompt settings | ||
| if (await promptSettings.isPromptEnabled('ssoCacheError')) { | ||
| if (promptSettings.isPromptEnabled('ssoCacheError')) { |
Contributor
There was a problem hiding this comment.
This is a welcome change 👍
Not a strong reason for this function to be async
Contributor
Author
There was a problem hiding this comment.
isolated this change here: https://github.com/aws/aws-toolkit-vscode/pull/6255/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ToolkitPromptSettingsandAmazonQPromptSettingsreimplement the same functions.Solution
TODO: figure out how to type the booleans to avoid casting
feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.