fix(e2e): failing Auth Lambda #6334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
|
/runIntegrationTests |
nkomonen-amazon
force-pushed
the
testAuthUtil
branch
from
e0d66b0 to
77db9cc
Compare
jpinkney-aws
approved these changes
Jan 10, 2025
justinmk3
approved these changes
Jan 10, 2025
Contributor
Author
|
/runIntegrationTests |
Contributor
|
nkomonen-amazon
force-pushed
the
testAuthUtil
branch
from
77db9cc to
f0b709b
Compare
Signed-off-by: nkomonen-amazon <[email protected]>
nkomonen-amazon
force-pushed
the
testAuthUtil
branch
from
f0b709b to
8dead79
Compare
Contributor
|
is the failing |
avi-alpert
pushed a commit
to avi-alpert/aws-toolkit-vscode
that referenced
this pull request
Jan 15, 2025
## Problem The CC tests are failing in the auth lambda step, saying that the `user_code` value is not a string ## Solution See code for solution NOTE: This part is now fixed, but the auth lambda itself has its own separate issue that needs to first be fixed --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: nkomonen-amazon <[email protected]>
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
## Problem The CC tests are failing in the auth lambda step, saying that the `user_code` value is not a string ## Solution See code for solution NOTE: This part is now fixed, but the auth lambda itself has its own separate issue that needs to first be fixed --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: nkomonen-amazon <[email protected]>
kevluu-aws
pushed a commit
to kevluu-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 23, 2025
## Problem The CC tests are failing in the auth lambda step, saying that the `user_code` value is not a string ## Solution See code for solution NOTE: This part is now fixed, but the auth lambda itself has its own separate issue that needs to first be fixed --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: nkomonen-amazon <[email protected]>
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem The CC tests are failing in the auth lambda step, saying that the `user_code` value is not a string ## Solution See code for solution NOTE: This part is now fixed, but the auth lambda itself has its own separate issue that needs to first be fixed --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: nkomonen-amazon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The CC tests are failing in the auth lambda step, saying that the
user_codevalue is not a stringSolution
See code for solution
NOTE: This part is now fixed, but the auth lambda itself has its own separate issue that needs to first be fixed
Handles issue #6318
feature/xbranches will not be squash-merged at release time.