-
Notifications
You must be signed in to change notification settings - Fork 751
fix(wizard): wizard remains in "not ready" state if a custom init() was provided #6339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice 👍 |
| // eslint-disable-next-line @typescript-eslint/unbound-method | ||
| const _init = this.init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can the eslint ignore be avoided, by something like:
| // eslint-disable-next-line @typescript-eslint/unbound-method | |
| const _init = this.init | |
| const _init = this.init.bind(this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out! I've replaced .apply(this) with .bind(this), which fixes the unbound method issue and removes the need for the ESLint comment.
justinmk3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will wait for reply to my comment
…as provided aws#6339 ## Problem The wizard remained in a "not ready" state if a custom `init()` was provided, requiring manual toggles in the test code. ## Solution - Wrap the user’s init() with a small decorator that sets _ready = true. - Remove the manual toggles in wizardTestUtils.ts, letting the wizard handle readiness on its own.
…as provided aws#6339 ## Problem The wizard remained in a "not ready" state if a custom `init()` was provided, requiring manual toggles in the test code. ## Solution - Wrap the user’s init() with a small decorator that sets _ready = true. - Remove the manual toggles in wizardTestUtils.ts, letting the wizard handle readiness on its own.
…as provided aws#6339 ## Problem The wizard remained in a "not ready" state if a custom `init()` was provided, requiring manual toggles in the test code. ## Solution - Wrap the user’s init() with a small decorator that sets _ready = true. - Remove the manual toggles in wizardTestUtils.ts, letting the wizard handle readiness on its own.
…as provided aws#6339 ## Problem The wizard remained in a "not ready" state if a custom `init()` was provided, requiring manual toggles in the test code. ## Solution - Wrap the user’s init() with a small decorator that sets _ready = true. - Remove the manual toggles in wizardTestUtils.ts, letting the wizard handle readiness on its own.
Problem
The wizard remained in a "not ready" state if a custom
init()was provided, requiring manual toggles in the test code.Solution
feature/xbranches will not be squash-merged at release time.