Skip to content

Conversation

@chungjac
Copy link
Contributor

Problem

  • NumOfUnitTestCasesGenerated shows non 0 value when LinesOfCodeGenerated and CharsOfCodeGenerated are 0
  • Occurs only when ExportResultArchive API did not have any generated code or when the job fails

Solution

  • Reset NumOfUnitTestCasesGenerated to 0 when one of these cases occur

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested a review from a team as a code owner January 13, 2025 18:13
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@ashishrp-aws ashishrp-aws merged commit 31200df into aws:master Jan 13, 2025
25 of 26 checks passed
@chungjac chungjac deleted the fix-test-number-discrepancy branch February 21, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants