fix(amazonq): add error message for README update too large #6347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
avi-alpert
changed the title
justinmk3
approved these changes
Jan 13, 2025
aggagen
approved these changes
Jan 13, 2025
auto-merge was automatically disabled
January 13, 2025 19:05
Pull request was closed
avi-alpert
added a commit
to avi-alpert/aws-toolkit-vscode
that referenced
this pull request
Jan 15, 2025
## Problem If a request to update a README results in an updated README that exceeds the size limit, a generic "I'm sorry, I ran into an issue updating your README" error is displayed. ## Solution Display a more specific error message when an updated README Exceeds the size limit --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
## Problem If a request to update a README results in an updated README that exceeds the size limit, a generic "I'm sorry, I ran into an issue updating your README" error is displayed. ## Solution Display a more specific error message when an updated README Exceeds the size limit --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
kevluu-aws
pushed a commit
to kevluu-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 23, 2025
## Problem If a request to update a README results in an updated README that exceeds the size limit, a generic "I'm sorry, I ran into an issue updating your README" error is displayed. ## Solution Display a more specific error message when an updated README Exceeds the size limit --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem If a request to update a README results in an updated README that exceeds the size limit, a generic "I'm sorry, I ran into an issue updating your README" error is displayed. ## Solution Display a more specific error message when an updated README Exceeds the size limit --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If a request to update a README results in an updated README that exceeds the size limit, a generic "I'm sorry, I ran into an issue updating your README" error is displayed.
Solution
Display a more specific error message when an updated README Exceeds the size limit
feature/xbranches will not be squash-merged at release time.