Skip to content

fix(amazonq): broaden search strings #6357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhasani23 merged 1 commit into from
Jan 14, 2025
Merged

fix(amazonq): broaden search strings #6357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/core/src/codewhisperer/commands/startTransformByQ.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,14 +654,14 @@ export async function getValidSQLConversionCandidateProjects() {
let resultLog = ''
for (const project of javaProjects) {
// as long as at least one of these strings is found, project contains embedded SQL statements
const searchStrings = ['oracle.jdbc.OracleDriver', 'jdbc:oracle:thin:@', 'jdbc:oracle:oci:@', 'jdbc:odbc:']
const searchStrings = ['oracle.jdbc.', 'jdbc:oracle:', 'jdbc:odbc:']
for (const str of searchStrings) {
const spawnResult = await findStringInDirectory(str, project.path)
// just for telemetry purposes
if (spawnResult.error || spawnResult.stderr) {
resultLog += `search failed: ${JSON.stringify(spawnResult)}`
resultLog += `search error: ${JSON.stringify(spawnResult)}--`
} else {
resultLog += `search succeeded: ${spawnResult.exitCode}`
resultLog += `search complete (exit code: ${spawnResult.exitCode})--`
}
getLogger().info(`CodeTransformation: searching for ${str} in ${project.path}, result = ${resultLog}`)
if (spawnResult.exitCode === 0) {
Expand Down
Loading