Skip to content

Conversation

@seshubaws
Copy link
Contributor

Problem

Several errors that were being shown to customers did not have enough information for them to take action on the problem.

Solution

Audited all errors and logs shown to customers and updated them to make them more legible and actionable.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@seshubaws seshubaws requested a review from a team as a code owner January 14, 2025 18:20
@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@seshubaws seshubaws changed the title fix(lambda): Update error messaging fix(lambda): Update error messaging in AppBuilder Jan 14, 2025
@Hweinstock
Copy link
Contributor

Looks like some tests need updating once the relevant changes are finalized:

3 failing
  1) generateDeployedNode
       LambdaFunctionNode
         should log error message given any lambda client error:

      AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ '[Failed to retrieve deployed resource. Please ensure stack name, region, and account credentials are correct.]'
- '[Failed to retrive deployed resource.]'
      + expected - actual

      -[Failed to retrieve deployed resource. Please ensure stack name, region, and account credentials are correct.]
      +[Failed to retrive deployed resource.]
      
      at Context.<anonymous> (/Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/packages/core/src/test/shared/applicationBuilder/explorer/nodes/deployedNode.test.ts:223:20)

  2) generateDeployedNode
       UnsupportedResourceNode
         should return a DeployedResourceNode with placeholder:

      AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ '[This resource is not yet supported in AppBuilder.]'
- '[This resource is not yet supported.]'
      + expected - actual

      -[This resource is not yet supported in AppBuilder.]
      +[This resource is not yet supported.]
      
      at Context.<anonymous> (/Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/packages/core/src/test/shared/applicationBuilder/explorer/nodes/deployedNode.test.ts:377:20)

  3) AppNode
       getChildren
         should return placeholder item when encounter error:

      AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ '[Unable to load resource tree for this app. Ensure SAM template is correct.]'
- '[Unable to load Resource tree for this App. Update SAM template]'
      + expected - actual

      -[Unable to load resource tree for this app. Ensure SAM template is correct.]
      +[Unable to load Resource tree for this App. Update SAM template]

@justinmk3 justinmk3 merged commit 9617649 into aws:master Jan 17, 2025
21 of 26 checks passed
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
## Problem
Several errors that were being shown to customers did not have enough
information for them to take action on the problem.

## Solution
Audited all errors and logs shown to customers and updated them to make
them more legible and actionable.
kevluu-aws pushed a commit to kevluu-aws/aws-toolkit-vscode that referenced this pull request Jan 23, 2025
## Problem
Several errors that were being shown to customers did not have enough
information for them to take action on the problem.

## Solution
Audited all errors and logs shown to customers and updated them to make
them more legible and actionable.
chungjac pushed a commit to chungjac/aws-toolkit-vscode that referenced this pull request Jan 24, 2025
## Problem
Several errors that were being shown to customers did not have enough
information for them to take action on the problem.

## Solution
Audited all errors and logs shown to customers and updated them to make
them more legible and actionable.
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
## Problem
Several errors that were being shown to customers did not have enough
information for them to take action on the problem.

## Solution
Audited all errors and logs shown to customers and updated them to make
them more legible and actionable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants