fix(amazonq): unsupported languages test generation query #6363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chungjac
approved these changes
Jan 14, 2025
justinmk3
changed the title
justinmk3
changed the title
justinmk3
reviewed
Jan 14, 2025
packages/amazonq/.changes/next-release/Bug Fix-cb743d9a-67da-41a2-bda3-9bc8bfa19b75.json
Outdated
Show resolved
Hide resolved
justinmk3
reviewed
Jan 14, 2025
packages/amazonq/.changes/next-release/Bug Fix-cb743d9a-67da-41a2-bda3-9bc8bfa19b75.json
Outdated
Show resolved
Hide resolved
Contributor
There's no need to recreate the PR. Just close-and-reopen the existing PR, that will trigger a new lint-commits job. This is explained in the lint-commits CI log. |
…1a2-bda3-9bc8bfa19b75.json Co-authored-by: Justin M. Keyes <[email protected]>
ctlai95
reviewed
Jan 14, 2025
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "type": "Bug Fix", | |||
| "description": "Amazon Q: test generation for unsupported was sometimes unreliable" | |||
Contributor
There was a problem hiding this comment.
nit: This will be listed under Amazon Q extension so no need to mention Amazon Q: here
Maybe instead you can prefix with /test:
ctlai95
reviewed
Jan 14, 2025
|
|
||
| const triggerPayload = { | ||
| query: `Generate unit tests for the following part of my code: ${message}`, | ||
| query: `Generate unit tests for the following part of my code: ${message?.trim() || fileName}`, |
Contributor
There was a problem hiding this comment.
Can you please describe how this fixes the issue in the PR description? (I'm assuming this is the fix)
Before/after screenshots would be helpful as well, if possible
ctlai95
approved these changes
Jan 15, 2025
hayemaxi
approved these changes
Jan 15, 2025
Contributor
hayemaxi
left a comment
hayemaxi
left a comment
There was a problem hiding this comment.
In future PRs please consider giving functions an options arguments instead of a bunch of arguments. It gets more and more confusing as arguments are added.
e.g.
// bad
myFunc(a, b, c, d ,e, f, g, ...) {}
// good
myFunc(options: Options) {}
type Options = {
a: int
b: string
....
}
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
## Problem - The test generation for unsupported language files and external files is unreliable and flaky. - Telemetry updated to include new metadata for existing metadata. ## Solution - Fix to add file name as fallback in case of empty prompt or no code selection. - Telemetry updated and values passed to it in controller and messenger. Essentially same PR : aws#6323 was closed last week due to build issues. --- Before: https://github.com/user-attachments/assets/90ed6629-4753-41e6-9d11-b6d4dd0d6e7c After fix: https://github.com/user-attachments/assets/d0993345-cd2c-47ac-a8b5-1e9badf8fbac - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Justin M. Keyes <[email protected]>
kevluu-aws
pushed a commit
to kevluu-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 23, 2025
## Problem - The test generation for unsupported language files and external files is unreliable and flaky. - Telemetry updated to include new metadata for existing metadata. ## Solution - Fix to add file name as fallback in case of empty prompt or no code selection. - Telemetry updated and values passed to it in controller and messenger. Essentially same PR : aws#6323 was closed last week due to build issues. --- Before: https://github.com/user-attachments/assets/90ed6629-4753-41e6-9d11-b6d4dd0d6e7c After fix: https://github.com/user-attachments/assets/d0993345-cd2c-47ac-a8b5-1e9badf8fbac - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Justin M. Keyes <[email protected]>
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem - The test generation for unsupported language files and external files is unreliable and flaky. - Telemetry updated to include new metadata for existing metadata. ## Solution - Fix to add file name as fallback in case of empty prompt or no code selection. - Telemetry updated and values passed to it in controller and messenger. Essentially same PR : aws#6323 was closed last week due to build issues. --- Before: https://github.com/user-attachments/assets/90ed6629-4753-41e6-9d11-b6d4dd0d6e7c After fix: https://github.com/user-attachments/assets/d0993345-cd2c-47ac-a8b5-1e9badf8fbac - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Justin M. Keyes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Before:
https://github.com/user-attachments/assets/90ed6629-4753-41e6-9d11-b6d4dd0d6e7c
After fix:
Screen.Recording.2025-01-15.at.12.22.15.PM.mov
feature/xbranches will not be squash-merged at release time.