test(/dev): state transitions #6367
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
changed the title
justinmk3
approved these changes
Jan 15, 2025
justinmk3
reviewed
Jan 15, 2025
Comment on lines
40
to
41
| sinon.stub(session, 'conversationId').get(() => conversationId) | ||
| sinon.stub(session, 'uploadId').get(() => uploadId) |
Contributor
There was a problem hiding this comment.
why can't you set state on the session ? why is a stub needed? stubs and mocks should be avoided where possible. they should be a last resort, not the first thing that is tried when state needs to be set.
Contributor
|
@karanA-aws please ensure that your github user belongs to a team in the https://github.com/aws org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.