Skip to content

fix(amazonq): rely on server-side data to communicate number of code generations remaining #6370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinmk3 merged 3 commits into from
Jan 15, 2025
Merged

fix(amazonq): rely on server-side data to communicate number of code generations remaining #6370

justinmk3 merged 3 commits into from
Jan 15, 2025

Conversation

@siakmun-aws
Copy link
Contributor

@siakmun-aws siakmun-aws commented Jan 14, 2025

Problem

Previously remaining code generation iterations are always displayed.

Solution

Only display when it goes down to 2 or less.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@siakmun-aws siakmun-aws changed the title fix(amazonq): conditionally display remaining code generation iterations feat(amazonq): conditionally display remaining code generation iterations Jan 14, 2025
neilk-aws
neilk-aws suggested changes Jan 14, 2025
View reviewed changes
@siakmun-aws
fix(amazonq): remove hard-coded limits and instead rely server-side d…
4302345 
…ata to communicate number of code generations remaining
@siakmun-aws siakmun-aws changed the title feat(amazonq): conditionally display remaining code generation iterations fix(amazonq): remove hard-coded limits and instead rely server-side data to communicate number of code generations remaining Jan 14, 2025
@github-actions
Copy link

github-actions bot commented Jan 14, 2025

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

siakmun-aws
siakmun-aws commented Jan 14, 2025
View reviewed changes
Copy link
Contributor Author

@siakmun-aws siakmun-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@siakmun-aws
fix(amazonq): remove hard-coded limits and instead rely server-side d…
429dd5e 
…ata to communicate number of code generations remaining
@siakmun-aws siakmun-aws changed the title fix(amazonq): remove hard-coded limits and instead rely server-side data to communicate number of code generations remaining fix(amazonq): rely on server-side data to communicate number of code generations remaining Jan 15, 2025
@siakmun-aws siakmun-aws reopened this Jan 15, 2025
@siakmun-aws siakmun-aws marked this pull request as ready for review January 15, 2025 00:13
@siakmun-aws siakmun-aws requested review from a team as code owners January 15, 2025 00:13
@justinmk3
Copy link
Contributor

justinmk3 commented Jan 15, 2025

Nice changelog!

I'll merge this for tomorrow's testing window. But please followup with a fix for the failing jscpd (copy-paste detection) issue.

@justinmk3 justinmk3 merged commit 2b047ac into aws:master Jan 15, 2025
22 of 24 checks passed
avi-alpert pushed a commit to avi-alpert/aws-toolkit-vscode that referenced this pull request Jan 15, 2025
@siakmun-aws @avi-alpert
fix(amazonq): use server-side data to decide remaining code generations
732364c 
aws#6370

## Problem
Previously remaining code generation iterations are always displayed.

## Solution
Only display when it goes down to 2 or less.
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
@siakmun-aws @karanA-aws
fix(amazonq): use server-side data to decide remaining code generations
4b87932 
aws#6370

Previously remaining code generation iterations are always displayed.

Only display when it goes down to 2 or less.
kevluu-aws pushed a commit to kevluu-aws/aws-toolkit-vscode that referenced this pull request Jan 23, 2025
@siakmun-aws @kevluu-aws
fix(amazonq): use server-side data to decide remaining code generations
b4d6719 
aws#6370

## Problem
Previously remaining code generation iterations are always displayed.

## Solution
Only display when it goes down to 2 or less.
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
@siakmun-aws @s7ab059789
fix(amazonq): use server-side data to decide remaining code generations
5f483ef 
aws#6370

## Problem
Previously remaining code generation iterations are always displayed.

## Solution
Only display when it goes down to 2 or less.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@neilk-aws neilk-aws neilk-aws approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siakmun-aws @justinmk3 @neilk-aws