-
Notifications
You must be signed in to change notification settings - Fork 751
telemetry(amazonq): Improving error handling and telemetry in unit test generation #6386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| /*! | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
| import { ToolkitError } from '../shared/errors' | ||
|
|
||
| export const technicalErrorCustomerFacingMessage = | ||
| 'I am experiencing technical difficulties at the moment. Please try again in a few minutes.' | ||
| const defaultTestGenErrorMessage = 'Amazon Q encountered an error while generating tests. Try again later.' | ||
| export class TestGenError extends ToolkitError { | ||
| constructor( | ||
| error: string, | ||
| code: string, | ||
| public uiMessage: string | ||
| ) { | ||
| super(error, { code }) | ||
| } | ||
| } | ||
| export class ProjectZipError extends TestGenError { | ||
| constructor(error: string) { | ||
| super(error, 'ProjectZipError', defaultTestGenErrorMessage) | ||
| } | ||
| } | ||
| export class InvalidSourceZipError extends TestGenError { | ||
| constructor() { | ||
| super('Failed to create valid source zip', 'InvalidSourceZipError', defaultTestGenErrorMessage) | ||
| } | ||
| } | ||
| export class CreateUploadUrlError extends TestGenError { | ||
| constructor(errorMessage: string) { | ||
| super(errorMessage, 'CreateUploadUrlError', technicalErrorCustomerFacingMessage) | ||
| } | ||
| } | ||
| export class UploadTestArtifactToS3Error extends TestGenError { | ||
| constructor(error: string) { | ||
| super(error, 'UploadTestArtifactToS3Error', technicalErrorCustomerFacingMessage) | ||
| } | ||
| } | ||
| export class CreateTestJobError extends TestGenError { | ||
| constructor(error: string) { | ||
| super(error, 'CreateTestJobError', technicalErrorCustomerFacingMessage) | ||
| } | ||
| } | ||
| export class TestGenTimedOutError extends TestGenError { | ||
| constructor() { | ||
| super( | ||
| 'Test generation failed. Amazon Q timed out.', | ||
| 'TestGenTimedOutError', | ||
| technicalErrorCustomerFacingMessage | ||
| ) | ||
| } | ||
| } | ||
| export class TestGenStoppedError extends TestGenError { | ||
| constructor() { | ||
| super('Unit test generation cancelled.', 'TestGenCancelled', 'Unit test generation cancelled.') | ||
| } | ||
| } | ||
| export class TestGenFailedError extends TestGenError { | ||
| constructor(error?: string) { | ||
| super(error ?? 'Test generation failed', 'TestGenFailedError', error ?? technicalErrorCustomerFacingMessage) | ||
| } | ||
| } | ||
| export class ExportResultsArchiveError extends TestGenError { | ||
| constructor(error?: string) { | ||
| super(error ?? 'Test generation failed', 'ExportResultsArchiveError', technicalErrorCustomerFacingMessage) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference: as mentioned in #6187 (comment) , this module is not a recommended pattern. Mirroring every single service error manually is a maintenance burden, and doesn't make sense. Either the generated SDK should do this or we should find a programmatic solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed....we are working on error handling on service side of things. Once those changes are ready. we will make changes here on plugin. But yes, essentially we will get proper errors from the service.