refactor(pollingset): make bad state impossible #6396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
it's only overriding, right? "overwrite" makes me think of |
Contributor
Author
|
Yes, only overriding. Updated the description to be more accurate. |
kevluu-aws
pushed a commit
to kevluu-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 23, 2025
## Problem Right now `PollingSet` exposes both the `add` and the `start` methods. The `start` adds the item and starts the timer, while the `add` only adds the item. This allows a consumer to create a non-empty `PollingSet` where the timer never started. ## Solution - override the add method so that a consumer is forced to start the timer when adding items.
chungjac
pushed a commit
to chungjac/aws-toolkit-vscode
that referenced
this pull request
Jan 24, 2025
## Problem Right now `PollingSet` exposes both the `add` and the `start` methods. The `start` adds the item and starts the timer, while the `add` only adds the item. This allows a consumer to create a non-empty `PollingSet` where the timer never started. ## Solution - override the add method so that a consumer is forced to start the timer when adding items.
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem Right now `PollingSet` exposes both the `add` and the `start` methods. The `start` adds the item and starts the timer, while the `add` only adds the item. This allows a consumer to create a non-empty `PollingSet` where the timer never started. ## Solution - override the add method so that a consumer is forced to start the timer when adding items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Right now
PollingSetexposes both theaddand thestartmethods. Thestartadds the item and starts the timer, while theaddonly adds the item.This allows a consumer to create a non-empty
PollingSetwhere the timer never started.Solution
feature/xbranches will not be squash-merged at release time.