Skip to content

ci(core): Request should not throw on 304 status #6400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpinkney-aws merged 1 commit into from
Jan 21, 2025
Merged

ci(core): Request should not throw on 304 status #6400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/core/src/shared/request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,11 @@ class FetchRequest {
}

async #throwIfBadResponse(request: RequestParams, response: Response, url: string) {
if (response.ok) {
/**
* response.ok only returns true for 200-299.
* We need to explicitly allow 304 since it means the cached version is still valid
*/
if (response.ok || response.status === 304) {
return
}

Expand Down
Loading