Skip to content

refactor(lint): migrate use of .forEach to for...of #6406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinmk3 merged 2 commits into from
Jan 22, 2025
Merged

refactor(lint): migrate use of .forEach to for...of #6406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d22435
migrate use of .forEach to for...of
Hweinstock Jan 21, 2025
a5cbe18
Merge branch 'feature/amazonqLSP' into lsp/forEach
Hweinstock Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/amazonq/src/inline/completion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
} from 'vscode'
import { LanguageClient } from 'vscode-languageclient'
import {
InlineCompletionItemWithReferences,
InlineCompletionListWithReferences,
InlineCompletionWithReferencesParams,
inlineCompletionWithReferencesRequestType,
Expand Down Expand Up @@ -104,13 +103,13 @@ export class AmazonQInlineCompletionItemProvider implements InlineCompletionItem
const firstCompletionDisplayLatency = Date.now() - requestStartTime

// Add completion session tracking and attach onAcceptance command to each item to record used decision
list.items.forEach((item: InlineCompletionItemWithReferences) => {
for (const item of list.items) {
item.command = {
command: 'aws.sample-vscode-ext-amazonq.accept',
title: 'On acceptance',
arguments: [list.sessionId, item.itemId, requestStartTime, firstCompletionDisplayLatency],
}
})
}

return list as InlineCompletionList
}
Expand Down
Loading