Skip to content

Conversation

@karanA-aws
Copy link
Contributor

Enhanced Development Prompt:

  • Modified GENERATE_DEV_FILE_PROMPT to support running install, build, and test commands independently.

Improved Build and Code File Upload Logic:

  • Updated the logic to enable uploading build files alongside code files

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@karanA-aws karanA-aws requested review from a team as code owners January 23, 2025 23:13
@karanA-aws karanA-aws changed the title Feature/q dev execution feat(/dev): Update file generation logic and file upload functionality for dev-execution. Jan 23, 2025
@karanA-aws karanA-aws closed this Jan 23, 2025
@karanA-aws karanA-aws reopened this Jan 23, 2025
@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@karanA-aws karanA-aws changed the title feat(/dev): Update file generation logic and file upload functionality for dev-execution. feat(dev): Update file generation logic and file upload functionality for dev-execution. Jan 23, 2025
@karanA-aws karanA-aws closed this Jan 23, 2025
@karanA-aws karanA-aws reopened this Jan 23, 2025
Copy link
Contributor

@osdemah osdemah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jpinkney-aws jpinkney-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really related to this PR but it looks like a lot of characters after a period aren't capitialized. The actual PR looks fine otherwise though

@jpinkney-aws jpinkney-aws merged commit 24bb920 into aws:feature/q-dev-execution Jan 24, 2025
27 of 36 checks passed
@justinmk3
Copy link
Contributor

This is failing lint.

export const codefileNames = new Set(['Dockerfile', 'Dockerfile.build', 'gradlew', 'mvnw'])

// Build file names
export const buildfileNames = new Set(['gradle/wrapper/gradle-wrapper.jar'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not add this to codefileNames?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants