Skip to content

Conversation

@Hweinstock
Copy link
Contributor

Problem

Currently seeing the following error on master

passes eslint:

      AssertionError [ERR_ASSERTION]: ,
/home/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/packages/core/src/shared/clients/s3Client.ts
Error:   468:[31](https://github.com/aws/aws-toolkit-vscode/actions/runs/12991583651/job/36229470175#step:6:32)  error  Delete `·`  prettier/prettier`

Solution

  • delete the extra space.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions

This comment was marked as resolved.

@Hweinstock Hweinstock marked this pull request as ready for review January 27, 2025 17:49
@Hweinstock Hweinstock requested a review from a team as a code owner January 27, 2025 17:49
@Hweinstock Hweinstock merged commit e54d549 into aws:master Jan 27, 2025
26 checks passed
@Hweinstock Hweinstock deleted the fix/prettier branch January 27, 2025 17:58
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
## Problem
Currently seeing the following error on master 
```
passes eslint:

      AssertionError [ERR_ASSERTION]: ,
/home/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/packages/core/src/shared/clients/s3Client.ts
Error:   468:[31](https://github.com/aws/aws-toolkit-vscode/actions/runs/12991583651/job/36229470175#step:6:32)  error  Delete `·`  prettier/prettier`
```

## Solution
- delete the extra space. 


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants