Skip to content

Conversation

@Hweinstock
Copy link
Contributor

Problem

The client should not be making requests with stale credentials so we want test coverage to ensure this

Solution

  • Create a mock credentials shim and insert it into the global context.
  • The client builder will then use that shim, and we can manually expire it.
  • Ensure client does not cache potentially stale credentials.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock Hweinstock marked this pull request as ready for review January 27, 2025 19:57
@Hweinstock Hweinstock requested a review from a team as a code owner January 27, 2025 19:58
accessKeyId: 'old',
secretAccessKey: 'old',
sessionToken: 'old',
expiration: new Date(Date.now() + 1000 * 60 * 60 * 24),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use these

// constants for working with milliseconds

@Hweinstock Hweinstock force-pushed the sdkv3/credentialsTesting3 branch from c006963 to f057c5e Compare January 28, 2025 16:03
@Hweinstock Hweinstock merged commit 6fc04c7 into aws:feature/sdkv3 Jan 28, 2025
17 checks passed
@Hweinstock Hweinstock deleted the sdkv3/credentialsTesting3 branch January 28, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants