fix(amazonq): For security reasons, disabled auto linkify for pure text links #6449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing in markdown other than [TEXT](URL) format
dogusata
changed the title
jpinkney-aws
approved these changes
Jan 28, 2025
This was referenced Feb 3, 2025
justinmk3
pushed a commit
that referenced
this pull request
Feb 3, 2025
## Problem - The citation links are broken after the [linkify structure change](#6449). ## Solution - Updated link check pattern to accept `[[TEXT]](LINK)` format too which is used for citations. **[MynahUI v4.22.1](https://github.com/aws/mynah-ui/releases/tag/v4.22.1)** [MynahUI PR](aws/mynah-ui#228)
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
…s#6449 ## Problem - Links incoming from Q responses can redirect to a vulnerable site depending on the used context from the files. ## Solution - Linkify strategy is updated to only accept links with `[TEXT](URL)` format. (through MynahUI version [4.21.6](https://github.com/aws/mynah-ui/releases/tag/v4.21.6)) MynahUI PR: aws/mynah-ui#226
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem - The citation links are broken after the [linkify structure change](aws#6449). ## Solution - Updated link check pattern to accept `[[TEXT]](LINK)` format too which is used for citations. **[MynahUI v4.22.1](https://github.com/aws/mynah-ui/releases/tag/v4.22.1)** [MynahUI PR](aws/mynah-ui#228)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
[TEXT](URL)format. (through MynahUI version 4.21.6)MynahUI PR:
aws/mynah-ui#226
feature/xbranches will not be squash-merged at release time.