Skip to content

test(flaky): avoid relying on race condition for tested behavior #6452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinmk3 merged 3 commits into from
Jan 30, 2025
Merged

test(flaky): avoid relying on race condition for tested behavior #6452

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dea07d6
fix: use stub to avoid race condition
Hweinstock Jan 28, 2025
186570f
test: add back expected telemetry metadata
Hweinstock Jan 28, 2025
c8707d7
telemetry: remove default emit
Hweinstock Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/core/src/test/shared/fs/fs.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,16 +411,20 @@ describe('FileSystem', function () {
const oldPath = testFolder.pathFrom('oldFile.txt')
const newPath = testFolder.pathFrom('newFile.txt')

const result = fs.rename(oldPath, newPath)
// this file is created after the first "exists" check fails, the following check should pass
void testutil.toFile('hello world', oldPath)
await result
const existsStub = Sinon.stub(FileSystem.prototype, 'exists')
existsStub.onFirstCall().resolves(false)
existsStub.callThrough()

await testutil.toFile('hello world', oldPath)
await fs.rename(oldPath, newPath)

testutil.assertTelemetry('ide_fileSystem', {
action: 'rename',
result: 'Succeeded',
reason: 'RenameRaceCondition',
})

existsStub.restore()
})
})

Expand Down
Loading