-
Notifications
You must be signed in to change notification settings - Fork 749
Merge feature/q-dev-execution: Amazon Q: Allow customers to configure the ability to run code and tests with /dev #6453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6430 ## Problem * Fixes for execution engine ## Solution * Don't drop binary files matching with extra gitignore rules * Don't drop `.gitignore` file from repository.
## Problem "Dev Command Workspace Configurations" is overly broad and too ambiguous with regards to what this setting enables. ## Solution Worked with tech writer to establish a different string to present to customers. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
osdemah
approved these changes
Jan 28, 2025
Merge master into feature/q-dev-execution
justinmk3
approved these changes
Jan 28, 2025
Contributor
|
/runintegrationtests |
Contributor
|
|
Contributor
Author
|
/runintegrationtests |
Contributor
|
Team has determined the failing e2e test is a test issue, not an application issue. Fast-followup work:
|
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem Customers cannot configure whether their generated code should be run and tested for quality assurance before being provided to them. ## Solution Enable customers to configure whether to run code and tests with /dev per project. On the first run of /dev for a project, if a devfile.yaml exists in the root of the project, the customer is prompted to know if they want to use the commands in the file to test the code we generate. The feature additionally allows customers to generate a devfile if one doesn't exist. Their choice is persisted and configurable in the Amazon Q settings. Co-authored-by: wilson <[email protected]> Co-authored-by: Justin M. Keyes <[email protected]> Co-authored-by: Karan Ahluwalia <[email protected]> Co-authored-by: Hamed Soleimani <[email protected]> Co-authored-by: Josh Pinkney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Today, customers cannot configure whether their generated code should be run and tested for quality assurance before being provided to them.
Solution
This feature enables customers to configure whether to run code and tests with /dev per project. On the first run of /dev for a project, if a devfile.yaml exists in the root of the project, the customer is prompted to know if they want to use the commands in the file to test the code we generate. The feature additionally allows customers to generate a devfile if one doesn't exist. Their choice is persisted and configurable in the Amazon Q settings.
feature/xbranches will not be squash-merged at release time.