Skip to content

fix(example): Add closing bracket to Amazon Q inline example #6454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2025
Merged

fix(example): Add closing bracket to Amazon Q inline example #6454

merged 2 commits into from
Feb 3, 2025

Conversation

@brandonskiser
Copy link
Contributor

@brandonskiser brandonskiser commented Jan 29, 2025 •
edited
Loading

Problem

The first Amazon Q inline suggestion example is missing a closing bracket, and the returned response often excludes it.

Solution

Simplifying the example by just including the closing bracket.

Notes

  • Failing tests and lints appear to be unrelated to the changes in this PR.
    • "RemoteFetcher" test failed, unrelated.
    • "lint-duplicate-code" is referencing unrelated code.
    • Just updating example code, so 0% code coverage is expected.
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brandonskiser
fix(example): Add closing bracket to Amazon Q inline example
3fd8a9d 
## Problem
The first Amazon Q inline suggestion example is missing a closing bracket,
and the returned response often excludes it.

## Solution
Simplifying the example by just including the closing bracket.
@brandonskiser brandonskiser requested review from a team as code owners January 29, 2025 00:58
@github-actions
Copy link

github-actions bot commented Jan 29, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@brandonskiser @hayemaxi
Update packages/amazonq/.changes/next-release/Bug Fix-e2bb3c83-52e8-4…
3e4088d 
…ae9-aedb-844e8780971b.json

Co-authored-by: Maxim Hayes <[email protected]>
hayemaxi
hayemaxi approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@hayemaxi hayemaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@justinmk3 justinmk3 merged commit 7af0b83 into aws:master Feb 3, 2025
24 of 26 checks passed
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
@brandonskiser @s7ab059789
fix(amazonq): add closing bracket to Amazon Q inline example aws#6454
b3e8c07 
## Problem
The first Amazon Q inline suggestion example is missing a closing
bracket, and the returned response often excludes it.

## Solution
Simplifying the example by just including the closing bracket.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@grant0417 grant0417 grant0417 approved these changes

@hayemaxi hayemaxi hayemaxi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brandonskiser @grant0417 @hayemaxi @justinmk3