Skip to content

Conversation

@tomcat323
Copy link
Contributor

@tomcat323 tomcat323 commented Feb 4, 2025

Problem

https://taskei.amazon.dev/tasks/IDE-15760
Users want to know that language servers are downloading

Solution

Add a status bar message when LSP is downloading
Also added a developer command to reset LSP download for testing

Screen.Recording.2025-02-04.at.2.31.27.PM.mov

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Feb 4, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@tomcat323 tomcat323 marked this pull request as ready for review February 4, 2025 19:34
@tomcat323 tomcat323 requested review from a team as code owners February 4, 2025 19:34
}

async tryInstallLsp(context: vscode.ExtensionContext): Promise<boolean> {
async tryInstallLsp(context: vscode.ExtensionContext, forceReset = false): Promise<boolean> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make these changes on the feature/amazonqLSP branch instead? I think the resolve() function in core/src/shared/lsp/lspResolver.ts could have this instead. That way you could log the language server name in addition to that its downloading

@tomcat323 tomcat323 closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants