-
Notifications
You must be signed in to change notification settings - Fork 749
feat(stepfunctions): Add a setting to opt out of WFS + minor changes #6501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stepfunctions): Add a setting to opt out of WFS + minor changes #6501
Conversation
|
c43a61a to
4b7638e
Compare
4b7638e to
590b319
Compare
| "default": true, | ||
| "description": "%AWS.stepFunctions.asl.format.enable.desc%" | ||
| }, | ||
| "aws.stepfunctions.workflowStudio.enable": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this setting being added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is explained in point 1:
The feature opens specific file types in a custom editor by default and customers don't have a way to optout while still using toolkit
Our team (including the UX) decided that since custom editor is opened by default, we want to provide a way for the user to opt out of it
justinmk3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is a setting being added? Not explained in the PR description. Looks like a low-value setting. Settings should not be added unless there is a strong use-case.
| "AWS.stepFunctions.workflowStudio.actions.progressMessage": "Opening asl file in Workflow Studio", | ||
| "AWS.stepFunctions.workflowStudio.actions.saveSuccessMessage": "{0} has been saved", | ||
| "AWS.stepFunctions.workflowStudio.actions.invalidJson": "The Workflow Studio editor was not opened because the JSON in the file is invalid. To access Workflow Studio, please fix the JSON and manually reopen the integration.", | ||
| "AWS.stepFunctions.workflowStudio.enable.desc": "Open Amazon States Language files in Workflow Studio by default.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use workbench.editorAssociations. We already do something similar for threat composer:
aws-toolkit-vscode/packages/toolkit/package.json
Lines 4412 to 4415 in 30face9
| "configurationDefaults": { | |
| "workbench.editorAssociations": { | |
| "{git,gitlens,conflictResolution,vscode-local-history}:/**/*.tc.json": "default" | |
| } |
Do not add new, custom ways of setting file associations.
|
After discussing offline, we agreed to not add that as a setting, as this is something that can be done with local config file. I'll cancel this PR since that change was its main content, and will publish other small changes in a separate PR |
Problem
Solution
resolveCustomTextEditor) it needs to be witched to default editor. Please advise if that's not the case and the custom editor mount can be prevented earlier (while keeping file format association with the file types)feature/xbranches will not be squash-merged at release time.