fix(amazonq): auto-review doesn't populate treeview #6502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
laileni-aws
approved these changes
Feb 4, 2025
ashishrp-aws
approved these changes
Feb 5, 2025
jpinkney-aws
approved these changes
Feb 5, 2025
Contributor
|
Going to merge this past the code freeze because teams haven't started verification and it seems important |
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem Issues detected by auto-review feature are not populating the code issues treeview list unless you run a manual `/review` first. <img width="1594" alt="Screenshot 2025-02-04 at 3 00 08 PM" src="https://github.com/user-attachments/assets/4b817fad-a17e-4ce6-8374-fb81634f18b1" /> This issue is happening because `vscode.window.createTreeView` is hidden inside `SecurityIssuesTree` class which only gets invoked when you call `SecurityIssuesTree.instance.focus()`. Since we don't want to focus the tree view for auto-reviews, the treeview itself is never created. ## Solution Move the treeview creation to activation so that it always gets created when the extension is activated --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issues detected by auto-review feature are not populating the code issues treeview list unless you run a manual
/reviewfirst.This issue is happening because
vscode.window.createTreeViewis hidden insideSecurityIssuesTreeclass which only gets invoked when you callSecurityIssuesTree.instance.focus(). Since we don't want to focus the tree view for auto-reviews, the treeview itself is never created.Solution
Move the treeview creation to activation so that it always gets created when the extension is activated
feature/xbranches will not be squash-merged at release time.