feat(lsp): notification message when downloading #6508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tomcat323
changed the title
tomcat323
changed the title
justinmk3
reviewed
Feb 5, 2025
| ) {} | ||
|
|
||
| // wraps the resolver to show download status message | ||
| async resolveWithProgress() { |
Contributor
There was a problem hiding this comment.
Not clear what this is intended to do, but I'll just mention that we have a pretty sophisticated progress wrapper: showProgressWithTimeout
which also supports Cancel. The ability to cancel is very important for most "progress" tasks.
|
jpinkney-aws
approved these changes
Feb 11, 2025
justinmk3
reviewed
Feb 12, 2025
| return await tryStageResolvers('getServer', serverResolvers, getServerVersion) | ||
|
|
||
| const timeout = new Timeout(5000) | ||
| await showMessageWithCancel(`Downloading '${this.lsName}' language server`, timeout) |
Contributor
There was a problem hiding this comment.
Is the cancel handled? I.e. it should actually cancel the download. Look for existing showMessageWithCancel to see examples.
When the user hits Cancel, it should actually cancel the download.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://taskei.amazon.dev/tasks/IDE-15760
Users want to know that language servers are downloading
Solution
Add a toast notification message with progress bar when LSP is downloading
Also added a developer command to reset LSP download for testing, and a "setup completed" log when downloaded.
Short demo:
Screen.Recording.2025-02-11.at.2.39.47.PM.mov
feature/xbranches will not be squash-merged at release time.