Skip to content

Conversation

@dknutsen
Copy link
Contributor

@dknutsen dknutsen commented Feb 6, 2025

Problem

The following filetypes are not currently supported in /dev:

  • .hbs (Handlebars)
  • .gjs/.gts (Glimmer JavaScript/Glimmer TypeScript)
  • .astro/.mdx (Astro)
  • .svelte (Svelte)
  • .erb/.rake (Ruby)

Solution

Add .hbs, .gjs, .gts, .astro, .mdx, .svelte, .erb, and .rake to list of supported file extensions


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds Q /dev support for .hbs, .gjs, .gts files.

The .hbs extension is for Handlebars template files.
The .gjs extension is for 'Glimmer JavaScript' files used in Ember components
The .gts extension is for 'Glimmer TypeScript' files which are the typed equivalent of .gjs
@dknutsen dknutsen requested a review from a team as a code owner February 6, 2025 22:40
@github-actions
Copy link

github-actions bot commented Feb 6, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@avi-alpert avi-alpert self-requested a review February 6, 2025 22:59
@avi-alpert avi-alpert merged commit b398769 into aws:master Feb 7, 2025
16 of 17 checks passed
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
…svelte files in /dev (aws#6523)

## Problem

The following filetypes are not currently supported in `/dev`:

- .hbs (Handlebars)
- .gjs/.gts (Glimmer JavaScript/Glimmer TypeScript)
- .astro/.mdx (Astro)
- .svelte (Svelte)
- .erb/.rake (Ruby)

## Solution

Add .hbs, .gjs, .gts, .astro, .mdx, .svelte, .erb, and .rake to list of
supported file extensions

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants