Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Feb 10, 2025

Problem

Followup of #6419

Team decides to only show a subset of prefetched session instead of all as it's too intrusive experience.

Solution

Only display prefetched sessions when the session ids are identical to the very first one.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review February 11, 2025 17:09
@Will-ShaoHua Will-ShaoHua requested review from a team as code owners February 11, 2025 17:09
@Will-ShaoHua Will-ShaoHua changed the title only show next session if both sessino ids are the same config(inline): only show next session if both sessino ids are the same Feb 11, 2025
@Will-ShaoHua Will-ShaoHua changed the title config(inline): only show next session if both sessino ids are the same config(amazonq): show next session if only both sessino ids are the same Feb 11, 2025
@Will-ShaoHua Will-ShaoHua changed the title config(amazonq): show next session if only both sessino ids are the same config(inline): show next session if only both sessino ids are the same Feb 11, 2025
@jpinkney-aws
Copy link
Contributor

@Will-ShaoHua can you add a problem/description? if its just a wip can you convert this to a draft PR

@Will-ShaoHua
Copy link
Contributor Author

yea i will make it a draft

@Will-ShaoHua Will-ShaoHua marked this pull request as draft February 11, 2025 17:19
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review February 11, 2025 19:06
Copy link
Contributor

@andrewyuq andrewyuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on hold while discussing whether first trigger and subsequent pre-fetch triggers share the same sessionId

@Will-ShaoHua Will-ShaoHua marked this pull request as draft February 12, 2025 04:28
@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented Feb 17, 2025

closing it as we have reverted the pre-fetch logics

@Will-ShaoHua Will-ShaoHua deleted the modelRouting branch February 17, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants