Skip to content

test(amazonq): wait for non-empty suggestion state #6554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

test(amazonq): wait for non-empty suggestion state #6554

wants to merge 2 commits into from

Conversation

@jpinkney-aws
Copy link
Contributor

@jpinkney-aws jpinkney-aws commented Feb 11, 2025

Problem

  • In some cases codewhisperer can emit an "Empty" suggestion state before emitting another telemetry event with "Reject"/"Accept". This introduced a couple e2e test failures/flakiness

Solution

  • Wait until we get a non "Empty" suggestion state in telemetry
  • emit more debugging information if a test fails
  • only test the last suggestion states value, since that's the one that actually corresponds to the users action
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested a review from a team as a code owner February 11, 2025 15:12
@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 11, 2025

/runIntegrationTests

1 similar comment
@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 11, 2025

/runIntegrationTests

@jpinkney-aws jpinkney-aws requested a review from a team as a code owner February 11, 2025 18:29
@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 11, 2025

/runIntegrationTests

@jpinkney-aws jpinkney-aws marked this pull request as draft February 11, 2025 19:08
@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 11, 2025

/runIntegrationTests

13 similar comments
@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 11, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 11, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 11, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 12, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 12, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 12, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 12, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 12, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 12, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 12, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 13, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 13, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 13, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 13, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 13, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 13, 2025

/runIntegrationTests

@jpinkney-aws
Copy link
Contributor Author

jpinkney-aws commented Feb 13, 2025

Closing this because after this change came in last night: #6567 to revert 50c91210736c1226e8bcb4c1af10fe29fe202ee7 the tests are fully functional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jpinkney-aws