Skip to content

perf(appbuilder): reduce number of ListRemoteTestEvent calls by remote invoke #6559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinmk3 merged 1 commit into from
Feb 12, 2025
Merged

perf(appbuilder): reduce number of ListRemoteTestEvent calls by remote invoke #6559

justinmk3 merged 1 commit into from
Feb 12, 2025

Conversation

@jonife
Copy link
Contributor

@jonife jonife commented Feb 11, 2025 •
edited
Loading

Problem

Today Remote Invoke call ListRemoteTestEvent every instances the webview is spun up. This pr introduces condition for which this api calls can be made thereby reducing the spike in number failures we see in our dashboard.

Note: we currently don't have test for frontend logic, however extensive testing was conducted.
Screenshot 2025-02-11 at 10 04 58 AM

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonife jonife requested a review from a team as a code owner February 11, 2025 18:00
@github-actions
Copy link

github-actions bot commented Feb 11, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jonife jonife changed the title fix(appbuilder): Introduce guard-rials to Remote Invoke calls to ListRemoteTestEvent refactor(appbuilder): Introduce guard-rials to Remote Invoke calls to ListRemoteTestEvent Feb 11, 2025
@jonife jonife changed the title refactor(appbuilder): Introduce guard-rials to Remote Invoke calls to ListRemoteTestEvent refactor(appbuilder): Introduce guard-rials to reduce number of ListRemoteTestEvent calls by remote invoke Feb 11, 2025
hayemaxi
hayemaxi approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@hayemaxi hayemaxi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending approval from your team, CI failure looks unrelated.

@justinmk3 justinmk3 changed the title refactor(appbuilder): Introduce guard-rials to reduce number of ListRemoteTestEvent calls by remote invoke refactor(appbuilder): reduce number of ListRemoteTestEvent calls by remote invoke Feb 12, 2025
@justinmk3 justinmk3 merged commit 7d5a339 into aws:master Feb 12, 2025
22 of 26 checks passed
@justinmk3 justinmk3 changed the title refactor(appbuilder): reduce number of ListRemoteTestEvent calls by remote invoke perf(appbuilder): reduce number of ListRemoteTestEvent calls by remote invoke Feb 12, 2025
@justinmk3
Copy link
Contributor

justinmk3 commented Feb 12, 2025

This is a logic change, not a refactor. And seems performance related too. Likely worth mentioning in the changelog.

s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
@jonife @s7ab059789
perf(appbuilder): reduce number of ListRemoteTestEvent calls by remot…
41d29ed 
…e invoke aws#6559

Problem:
Remote Invoke call ListRemoteTestEvent every time the webview is instantiated. 

Solution:
Introduce a condition for which this api calls can be
made thereby reducing the spike in number failures we see in our
dashboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@jpinkney-aws jpinkney-aws jpinkney-aws approved these changes

@hayemaxi hayemaxi hayemaxi approved these changes

@vicheey vicheey vicheey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jonife @justinmk3 @jpinkney-aws @hayemaxi @vicheey