Skip to content

Conversation

@chungjac
Copy link
Contributor

@chungjac chungjac commented Feb 11, 2025

Problem

  • /test and /review are missing thumbs up/down telemetry
  • /test is missing feedback functionality
Screenshot 2025-02-11 at 1 58 42 PM Screenshot 2025-02-11 at 1 58 48 PM

Solution

  • send telemetry event for thumps up/down for /test and /review
  • send user feedback for /test which routes to SIM folder
  • No tests were added as this is UX change

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested review from a team as code owners February 11, 2025 21:56
@chungjac chungjac force-pushed the feedback-functionality branch from 8f7dae3 to 505ad34 Compare February 11, 2025 21:56
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

Copy link
Contributor

@laileni-aws laileni-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chungjac chungjac enabled auto-merge (squash) February 11, 2025 23:51
@chungjac chungjac merged commit 20975a6 into aws:master Feb 12, 2025
25 of 26 checks passed
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
…ws#6560)

## Problem
- /test and /review are missing thumbs up/down telemetry
- /test is missing feedback functionality

<img width="545" alt="Screenshot 2025-02-11 at 1 58 42 PM"
src="https://github.com/user-attachments/assets/11a46136-46a6-4d35-a7e1-e92f45b1034a"
/>
<img width="558" alt="Screenshot 2025-02-11 at 1 58 48 PM"
src="https://github.com/user-attachments/assets/80288c37-a98c-4e8f-9e32-810238ee2695"
/>


## Solution
- send telemetry event for thumps up/down for /test and /review
- send user feedback for /test which routes to SIM folder
- No tests were added as this is UX change

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
@chungjac chungjac deleted the feedback-functionality branch March 13, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants