Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/filterDuplicates.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,6 @@ async function run() {
console.log('%s duplicates found', filteredDuplicates.length)
if (filteredDuplicates.length > 0) {
console.log(formatDuplicates(filteredDuplicates, commitHash, repoName))
console.log(
'* Hint: if these duplicates appear unrelated to the changes, rebase onto the latest target branch.'
)
process.exit(1)
}
}
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,17 @@ jobs:
git remote add forkUpstream https://github.com/$REPO_NAME # URL of the fork
git fetch forkUpstream # Fetch fork

- name: Merge in target branch to avoid false negatives.
env:
TARGET_BRANCH: ${{ github.event.pull_request.base.ref }}
# Note: "git merge" should always succeed here, because GHA won't
# start the job if there are merge conflicts. https://github.com/orgs/community/discussions/11265
# Also, because `git merge` makes a commit, we need to establish an identity to avoid 'Committer identity unknown' error
run: |
git config --global user.name "aws-toolkit-automation"
git config --global user.email "<>"
git merge origin/$TARGET_BRANCH

- name: Compute git diff
env:
CURRENT_BRANCH: ${{ github.head_ref }}
Expand Down
Loading