test(auth): avoid deprecated InputBox usage that caused flakiness.

[Hweinstock]

Problem

#6594

The getMfaCodeFromUser currently uses a deprecated version of createInputBox and the following promptUser function:

aws-toolkit-vscode/packages/core/src/shared/ui/input.ts

Lines 72 to 135 in 0fa1b5b

	export async function promptUser({
	inputBox,
	onValidateInput,
	onDidTriggerButton,
	}: {
	inputBox: vscode.InputBox
	onValidateInput?(value: string): string | undefined
	onDidTriggerButton?(
	button: vscode.QuickInputButton,
	resolve: (value: string | PromiseLike<string | undefined> | undefined) => void,
	reject: (reason?: any) => void
	): void
	}): Promise<string | undefined> {
	const disposables: vscode.Disposable[] = []
	try {
	const response = await new Promise<string | undefined>((resolve, reject) => {
	inputBox.onDidAccept(
	() => {
	if (!inputBox.validationMessage) {
	resolve(inputBox.value)
	}
	},
	inputBox,
	disposables
	)
	inputBox.onDidHide(
	() => {
	resolve(undefined)
	},
	inputBox,
	disposables
	)
	if (onValidateInput) {
	inputBox.onDidChangeValue(
	(value) => {
	inputBox.validationMessage = onValidateInput(value)
	},
	inputBox,
	disposables
	)
	}
	if (onDidTriggerButton) {
	inputBox.onDidTriggerButton(
	(btn: vscode.QuickInputButton) => onDidTriggerButton(btn, resolve, reject),
	inputBox,
	disposables
	)
	}
	inputBox.show()
	})
	return response
	} finally {
	for (const d of disposables) {
	d.dispose() as void
	}
	inputBox.hide()
	}
	}

Based on the stack trace, there is a race condition here that can lead to a type error, but unsure how?
Stack trace:

TypeError: inputBox.hide is not a function
      at promptUser (/Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/packages/core/src/shared/ui/input.ts:133:18)
      at async getMfaTokenFromUser (/Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/packages/core/src/auth/credentials/utils.ts:124:19)
      at async /Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/packages/core/src/auth/providers/sharedCredentialsProvider.ts:422:38

Investigation Notes:

• The error only happens when running the test suite as a whole.
• The error only happens in CI (unable to reproduce locally).

Solution

• avoid use of deprecated createInputBox function, prefer new version instead.
• Ran the tests 4x with 1000x on the test, and did not see a failure.

Future Work

• Migrate existing cases away from this deprecated createInputBox if there is evidence it leads to flaky tests or unreliable behavior.

---

• Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
• Your code changes must meet the guidelines in CONTRIBUTING.md.
• License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

[jpinkney-aws]

Could part of the problem be because we override vscode.window in our unit tests?

• https://github.com/aws/aws-toolkit-vscode/blob/master/packages/core/src/test/shared/vscode/window.ts#L250
• https://github.com/aws/aws-toolkit-vscode/blob/master/packages/core/src/test/globalSetup.test.ts#L90

[Hweinstock]

Yea, I was digging through that code a bit, and suspect its making some assumptions about how we create our prompters. Its still unclear to me how the old createInputBox break those assumptions.