-
Notifications
You must be signed in to change notification settings - Fork 749
feat(amazonq): manifest deprecation message with optional don't show #6604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tomcat323
commented
Feb 18, 2025
justinmk3
reviewed
Feb 19, 2025
justinmk3
reviewed
Feb 19, 2025
jpinkney-aws
approved these changes
Mar 10, 2025
justinmk3
reviewed
Mar 13, 2025
| "ssoCacheError": {} | ||
| "ssoCacheError": {}, | ||
| "AmazonQLspManifestMessage": {}, | ||
| "AmazonQ-WorkspaceLspManifestMessage":{} |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this not follow the existing naming convention, which is found in the items just above this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the language server manifest is deprecated we just show it in the logs. However, users may not be explicitly aware that they will need to upgrade the extension to get a different manifest.
Also according to the design specsheet, user should have the option to mute the message for good once seen.
Solution
don't showandokbuttons for deprecated LSP manifest.don't showtrackingNote
Also added language server name in logs, helpful to track different instances
feature/xbranches will not be squash-merged at release time.