Skip to content

Conversation

@tomcat323
Copy link
Contributor

@tomcat323 tomcat323 commented Feb 18, 2025

Problem

If the language server manifest is deprecated we just show it in the logs. However, users may not be explicitly aware that they will need to upgrade the extension to get a different manifest.

Also according to the design specsheet, user should have the option to mute the message for good once seen.

Solution

  • Added a message window with don't show and ok buttons for deprecated LSP manifest.
  • Use AmazonQ suppressed prompts for don't show tracking
  • Added a re-enable feature so that we can re-enable that setting if manifest gets updated.

Note

Also added language server name in logs, helpful to track different instances


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@aws aws deleted a comment from jpinkney-aws Feb 18, 2025
@tomcat323 tomcat323 marked this pull request as ready for review February 18, 2025 15:24
@tomcat323 tomcat323 requested a review from a team as a code owner February 18, 2025 15:24
@tomcat323 tomcat323 marked this pull request as draft February 18, 2025 15:57
@tomcat323 tomcat323 marked this pull request as ready for review February 18, 2025 21:13
@justinmk3 justinmk3 changed the title feat(amazonq): manifest depreciation message with optional don't show feat(amazonq): manifest deprecation message with optional don't show Feb 19, 2025
@tomcat323 tomcat323 merged commit 8a34c79 into aws:feature/amazonqLSP Mar 12, 2025
16 of 17 checks passed
"ssoCacheError": {}
"ssoCacheError": {},
"AmazonQLspManifestMessage": {},
"AmazonQ-WorkspaceLspManifestMessage":{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this not follow the existing naming convention, which is found in the items just above this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants