Skip to content

Conversation

@Hweinstock
Copy link
Contributor

Problem

The AWS SDK now supports built-in pagination: https://aws.amazon.com/blogs/developer/pagination-using-async-iterators-in-modular-aws-sdk-for-javascript/
Currently, have our own logic build on top of calls to do this logic for us. However, the SDK paginators are likely more reliable, and avoids reimplementing logic. They are also part of the SDK making them easier to integrate with (specifically for types).

Doing this early in the migration process has the potential to reduce a lot of unnecessary code.

Solution

  • Migrate existing use cases of sdkv3 to use these paginators.
  • Create general support for them in the Wrapper class.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@Hweinstock Hweinstock changed the title refactor(sdkv3): switch to using built-in sdkv3 paginators. refactor(sdkv3): switch to using built-in sdkv3 pagination. Feb 21, 2025
@Hweinstock Hweinstock marked this pull request as ready for review February 21, 2025 21:19
@Hweinstock Hweinstock requested a review from a team as a code owner February 21, 2025 21:19
@Hweinstock Hweinstock merged commit 88bcf08 into aws:feature/sdkv3 Feb 24, 2025
28 of 33 checks passed
@Hweinstock Hweinstock deleted the sdkv3/paginators branch February 24, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants