fix(amazonq): ignored lines should not show up in /review scan issues #6659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ctlai95
reviewed
Feb 22, 2025
| const aggregatedCodeScanIssue: AggregatedCodeScanIssue = { | ||
| filePath: filePath, | ||
| issues: issues.map((issue) => mapRawToCodeScanIssue(issue, editor, jobId, scope)), | ||
| issues: issues.map((issue) => mapRawToCodeScanIssue(issue, jobId, scope, document)), |
Contributor
There was a problem hiding this comment.
nit: you can make this change even smaller by keeping the position of the editor/document argument the same
hayemaxi
approved these changes
Feb 24, 2025
ctlai95
reviewed
Feb 26, 2025
| }) | ||
|
|
||
| function getWorkspaceFolder(): string { | ||
| return path.join(__dirname, '../../../../../../core/dist/src/testFixtures/workspaceFolder') |
Contributor
There was a problem hiding this comment.
Can we use the src path instead of the dist path?
| nextToken: nextToken ? 'nextToken' : undefined, | ||
| }) | ||
|
|
||
| function getWorkspaceFolder(): string { |
Contributor
There was a problem hiding this comment.
can we use something like vscode.workspace.workspaceFolders[0].uri instead ? Aren't we already in the workspace folder?
ctlai95
reviewed
Feb 26, 2025
packages/amazonq/test/unit/codewhisperer/service/securityScanHandler.test.ts
Outdated
Show resolved
Hide resolved
…andler.test.ts Co-authored-by: Tai Lai <[email protected]>
ctlai95
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running a new
/reviewscan, Q fails to respect previously added ignore line, causing ignored issues to reappear in subsequent reviews.Solution
Fixed incorrect filter logic on ignoring single line issue
Old unit tests for
listScanResultswill not work after this change. So in addition, I improved all ofsecurityScanHandler's unit tests to not use any file stubs to better simulate real environment.feature/xbranches will not be squash-merged at release time.