Skip to content

Conversation

@avi-alpert
Copy link
Contributor

Problem

Strings were hardcoded in .ts and test files. Input placeholder text did not include information about using @ to insert context

Solution

Move strings to language file, update placeholder text to match figma.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@avi-alpert avi-alpert requested review from a team as code owners February 25, 2025 15:59
@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@avi-alpert
Copy link
Contributor Author

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

There will be one changelog entry added to encapsulate all falcon changes before branch is merged with master

@jpinkney-aws
Copy link
Contributor

jpinkney-aws commented Feb 26, 2025

/runIntegrationTests

1 similar comment
@avi-alpert
Copy link
Contributor Author

/runIntegrationTests

@avi-alpert
Copy link
Contributor Author

avi-alpert commented Feb 26, 2025

E2E tests are failing due to code changes in this PR, will push a fix

edit: I noticed that E2E tests are failing in commits in feature/falcon, likely due to changes in Mynah library since this branch is using beta. Will investigate

@avi-alpert
Copy link
Contributor Author

/runIntegrationTests

1 similar comment
@avi-alpert
Copy link
Contributor Author

/runIntegrationTests

@avi-alpert
Copy link
Contributor Author

avi-alpert commented Feb 26, 2025

The last failing E2E test is stumping me, its only happening in stable and I don't think its related to this PR. Unable to reproduce on local. I saw it failed earlier in https://d1ihu6zq92vp9p.cloudfront.net/1c9da8f0-ce74-4555-b368-afcad7647a82/report.html

@jpinkney-aws jpinkney-aws merged commit 6618b71 into aws:feature/falcon Feb 26, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants