-
Notifications
You must be signed in to change notification settings - Fork 749
fix(amazonq): remove hardcoded strings, update placeholder #6670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(amazonq): remove hardcoded strings, update placeholder #6670
Conversation
|
There will be one changelog entry added to encapsulate all falcon changes before branch is merged with master |
|
/runIntegrationTests |
1 similar comment
|
/runIntegrationTests |
|
E2E tests are failing due to code changes in this PR, will push a fix edit: I noticed that E2E tests are failing in commits in feature/falcon, likely due to changes in Mynah library since this branch is using beta. Will investigate |
|
/runIntegrationTests |
1 similar comment
|
/runIntegrationTests |
|
The last failing E2E test is stumping me, its only happening in stable and I don't think its related to this PR. Unable to reproduce on local. I saw it failed earlier in https://d1ihu6zq92vp9p.cloudfront.net/1c9da8f0-ce74-4555-b368-afcad7647a82/report.html |
Problem
Strings were hardcoded in .ts and test files. Input placeholder text did not include information about using @ to insert context
Solution
Move strings to language file, update placeholder text to match figma.
feature/xbranches will not be squash-merged at release time.