feat(amazonq): generate scanName from workspace config #6679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Author
|
/runIntegrationTests |
zuoyaofu
approved these changes
Feb 27, 2025
jpinkney-aws
reviewed
Mar 3, 2025
packages/amazonq/test/unit/codewhisperer/service/securityScanHandler.test.ts
Outdated
Show resolved
Hide resolved
ctlai95
added a commit
to ctlai95/aws-toolkit-vscode
that referenced
this pull request
Mar 5, 2025
This reverts commit 62d3ec1.
nkomonen-amazon
pushed a commit
that referenced
this pull request
Mar 6, 2025
This reverts commit 62d3ec1. ## Problem Scan name change is causing unexpected behavior from the service. ## Solution Temporarily revert this change --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All code scans are run with a scanName as a UUID which makes it impossible to track the bug lifecycle of projects. We are not leveraging the bug tracking feature which allows grouping together different scan runs of the same project by passing in the same scanName between runs.
Solution
Calculate the scanName using ClientID, the current workspace configuration (project root(s) or active file), and code analysis scope.
feature/xbranches will not be squash-merged at release time.