-
Notifications
You must be signed in to change notification settings - Fork 749
fix(amazonq): /test file collection usecase adds more patterns to filtering. #6681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
jpinkney-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we would get rid of this from processSourceFiles as well. I'm guessing this is neccessary for this release though?
FWIW you can see the consequence of this all throughout the zipUtil package. Theres generateZip and generateZipTestGen which already do very similiar things
jpinkney-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci is failing
Yes...necessary there to differentiate usage for review and test |
Problem
/test has been seeing quite a lot of failures due to file paylaod limit exceeded errors in past weeks in both IDEs but in last week there has been huge rise in these errors for /test on VSCode.
Solution
We have noticed a change that ignores to use default patterns in file filtering was introduced in PR #6561 . We have also collected data from internal customers by adding payload manifest in JetBrains for these errors and compiled a list of extensions which are causing this issue. We have decided to add these patterns to ignore list on VSCode as well.
feature/xbranches will not be squash-merged at release time.