Skip to content

telemetry(amazonq): missing autoDetected for metrics #6704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

telemetry(amazonq): missing autoDetected for metrics #6704

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9752873
telemetry(amazonq): missing autoDetected for metrics
ctlai95 Mar 3, 2025
0ce8aa4
Merge branch 'master' into missing-telemetry
ctlai95 Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"skippedTestReport": "ts-node ./scripts/skippedTestReport.ts ./packages/amazonq/test/e2e/"
},
"devDependencies": {
"@aws-toolkits/telemetry": "^1.0.296",
"@aws-toolkits/telemetry": "^1.0.301",
"@playwright/browser-chromium": "^1.43.1",
"@stylistic/eslint-plugin": "^2.11.0",
"@types/he": "^1.2.3",
Expand Down
3 changes: 3 additions & 0 deletions packages/core/src/codewhisperer/commands/basicCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,7 @@ export const openSecurityIssuePanel = Commands.declare(
detectorId: targetIssue.detectorId,
ruleId: targetIssue.ruleId,
credentialStartUrl: AuthUtil.instance.startUrl,
autoDetected: targetIssue.autoDetected,
})
TelemetryHelper.instance.sendCodeScanRemediationsEvent(
undefined,
Expand Down Expand Up @@ -834,6 +835,7 @@ export const ignoreAllIssues = Commands.declare(
findingId: targetIssue.findingId,
ruleId: targetIssue.ruleId,
variant: 'all',
autoDetected: targetIssue.autoDetected,
})
})
}
Expand Down Expand Up @@ -867,6 +869,7 @@ export const ignoreIssue = Commands.declare(
detectorId: targetIssue.detectorId,
findingId: targetIssue.findingId,
ruleId: targetIssue.ruleId,
autoDetected: targetIssue.autoDetected,
})
})
}
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/codewhisperer/service/securityIssueHoverProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export class SecurityIssueHoverProvider implements vscode.HoverProvider {
ruleId: issue.ruleId,
includesFix: !!issue.suggestedFixes.length,
credentialStartUrl: AuthUtil.instance.startUrl,
autoDetected: issue.autoDetected,
})
TelemetryHelper.instance.sendCodeScanRemediationsEvent(
document.languageId,
Expand Down
Loading