Skip to content

Conversation

@leigaol
Copy link
Contributor

@leigaol leigaol commented Mar 4, 2025

Problem

In Windows, the rules under .amazonq/rules were not send in the chat prompt because of path resolution failure.

Solution

Screenshot 2025-03-04 at 3 34 34 PM
Use path.join instead of vscode.Uri.joinPath


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner March 4, 2025 23:35
@leigaol leigaol requested a review from avi-alpert March 4, 2025 23:35
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@nkomonen-amazon nkomonen-amazon merged commit df6ebb0 into aws:master Mar 5, 2025
23 of 26 checks passed
workspaceFolder: workspaceFolderPath,
type: 'file' as ContextCommandItemType,
relativePath: path.relative(workspaceFolderPath, rule.path),
relativePath: path.relative(workspaceFolderPath, rule),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using rule.fsPath may have fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants