Skip to content

Conversation

@chungjac
Copy link
Contributor

@chungjac chungjac commented Mar 7, 2025

Problem

  • API has been refactored with new fields
  • shortAnswer will eventually be deprecated
  • new field jobSummary which has a summary about tests that were generated

Solution

  • implemented new field: packageInfoList and its subfields
  • display test summary in chat
Screen.Recording.2025-03-11.at.10.59.44.AM.mov

TODO:

  • integrate new API fields: buildCommand (once build exec is released), packageSummary, fileSummary, etc
  • remove all unused instances of shortAnswer

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@chungjac chungjac marked this pull request as ready for review March 7, 2025 19:08
@chungjac chungjac requested review from a team as code owners March 7, 2025 19:08
}

// TODO: remove ShortAnswer because it will be deprecated
export interface ShortAnswer {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this ShortAnswer being used any where in the project apart from build and execute in public master branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not being used anywhere else. I will eventually delete this after I do the shortAnswer refactoring for build exec

Copy link
Contributor

@laileni-aws laileni-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can you do E2E testing in these 3 scenarios?

  • Success(both ACCEPTED/REJECTED)
  • Failed
  • Cancelled

@chungjac
Copy link
Contributor Author

chungjac commented Mar 7, 2025

Completed testing for success, failed, and cancelled scenarios

@chungjac chungjac changed the title refactor(amazonq): refactor shortAnswer to accommodate API changes feat(amazonq): display test plan summary and refactor shortAnswer to accommodate API changes Mar 11, 2025
just testgen related objects

extractShortAnswer:

use packageInfoList
@chungjac chungjac force-pushed the shortanswer-refactoring branch from a650f54 to 3d51874 Compare March 11, 2025 21:04
@chungjac chungjac requested a review from a team as a code owner March 11, 2025 21:04
@chungjac chungjac force-pushed the shortanswer-refactoring branch from 3d51874 to 6f21d06 Compare March 11, 2025 21:08
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@chungjac chungjac removed the request for review from a team March 11, 2025 21:28
@chungjac chungjac merged commit 40db8b8 into aws:master Mar 11, 2025
25 of 26 checks passed
@chungjac chungjac deleted the shortanswer-refactoring branch October 8, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants