test(amazonq): add language server activation tests #6773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/runIntegrationTests |
Contributor
|
The E2E failures seen here should be fixed in 643ae10. |
jpinkney-aws
force-pushed
the
workspace-tests
branch
from
50a3ccb to
68b3551
Compare
Hweinstock
reviewed
Mar 13, 2025
| describe('AmazonQLSP', () => { | ||
| createLspInstallerTests({ | ||
| suiteName: 'AmazonQLSPInstaller', | ||
| lspConfig: getAmazonQLspConfig(), |
Contributor
There was a problem hiding this comment.
Are you stubbing the DevSettings.Instance (part of this config) to avoid bleed through between the tests?
Is there any reason we should/shouldn't reset this between tests so you can use the real object?
Contributor
Author
There was a problem hiding this comment.
good call out, I think for these tests we can just use the default config directly instead of the one that pulls from default/env vars/settings. I made a fixup pr that changes that
Hweinstock
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.