Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

Problem

  • missing diagrams for how the chat activation flow will work in flare
  • missing diagrams for how e2e test should work in flare

Solution

  • add missing diagrams
  • remove lsp debugging in favour of general lsp documentation

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested a review from a team as a code owner March 12, 2025 13:31
- Run requests directly against the backend and see if we get results back
- Clicking any follow up buttons (including examples)

## Flare Chat E2E Test flow (Not implemented yet)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know where this one should live. The old approach has nothing to do with language servers but the new one will so technically this could live in here or lsp.md

Copy link
Contributor

@justinmk3 justinmk3 Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one doc (instead of many) for test info is useful. I wonder why TEST_E2E is not part of TESTPLAN (which could be renamed)

@jpinkney-aws jpinkney-aws merged commit 02c3b99 into aws:feature/amazonqLSP Mar 13, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants