Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

Problem

  • Downloading the manifest/language server blocks showing the chat UI, creating a 2+ second increase between the UI showing with the feature flag enabled vs disabled

Solution

  • Don't block extension activation on downloading
    • If any code requires the language server to be started it should live alongside it

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested a review from a team as a code owner March 12, 2025 19:50
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@hayemaxi
Copy link
Contributor

To determine the auth state, we will have to use the LSP. If things activate while it is still initializing, the initial auth state will be incorrect. So we may end up displaying a not logged in state (or a logged in state if we want), but that may not be true until we contact the LSP. This might look weird to the user.

@jpinkney-aws
Copy link
Contributor Author

Sync'd with Max on this. For simplification it makes sense to close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants