feat(sdkv3): centralize and improve client logging and error handling. #6780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
callfunctionality should be available to other clients.calllogged performance and header information on failures, and allowed for silent failure with fallback values.<Error>.codeis no longer reliably defined.Solution
callimplementation in CodeCatalyst to live withinmakeRequest, such that failures in the genericClientWrapperlog performance and allow fallback values.code, thenCode, then fallback toname. Noticed some errors includedCode, but not all.Examples
On successful api request logs:
On failing API request logs:
the
[manually-omitted]field were removed by hand and exist in the original logs.Future Work
feature/xbranches will not be squash-merged at release time.