ci(changelog): escape changelog for notify, default entry when no changes #6784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges - Escape the changelog string using `jq` before sending to the notify url. Otherwise, things like quotes might cause the payload to fail. - If there are no new changes to release, post a generic entry for tracking purposes - Informs that the version is uneventful, and clears up the special case of handling this for release. - Fixes things that use the changelog, like notify, prerelease, etc. Otherwise, it will use previous version changelog.
justinmk3
approved these changes
Mar 13, 2025
Contributor
justinmk3
left a comment
justinmk3
left a comment
There was a problem hiding this comment.
Yay! This was something we wanted for a long time :D
jpinkney-aws
approved these changes
Mar 14, 2025
jpinkney-aws
pushed a commit
to jpinkney-aws/aws-toolkit-vscode
that referenced
this pull request
Mar 20, 2025
…nges (aws#6784) - Escape the changelog string using `jq` before sending to the notify url. Otherwise, things like quotes might cause the payload to fail. - If there are no new changes to release, post a generic entry for tracking purposes - Informs that the version is uneventful, and clears up the special case of handling this for release. - Fixes things that use the changelog, like notify, prerelease, etc. Otherwise, it will use previous version changelog. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jqbefore sending to the notify url. Otherwise, things like quotes might cause the payload to fail.feature/xbranches will not be squash-merged at release time.